Skip to content

fix(core): asset fingerprint cache invalidation incorrectly uses mtime#21374

Merged
RomainMuller merged 7 commits intomainfrom
rmuller/fix-cache-fingerprint
Jul 29, 2022
Merged

fix(core): asset fingerprint cache invalidation incorrectly uses mtime#21374
RomainMuller merged 7 commits intomainfrom
rmuller/fix-cache-fingerprint

Conversation

@RomainMuller
Copy link
Copy Markdown
Contributor

Instead of using the complete mtime value, it only accounted for the day-of-month
and fractional seconds part of the timestamp, which is not the intention.

The issue was introduced in #21321


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Instead of using the complete mtime value, it only accounted for the day-of-month
and fractional seconds part of the timestamp, which is not the intention.
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 29, 2022

@github-actions github-actions bot added the p2 label Jul 29, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 29, 2022 11:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 29, 2022
@RomainMuller RomainMuller added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 29, 2022
@RomainMuller RomainMuller merged commit 65a210a into main Jul 29, 2022
@RomainMuller RomainMuller deleted the rmuller/fix-cache-fingerprint branch July 29, 2022 13:33
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 22308de
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants