fix(ses): incorrect DKIM records for EmailIdentity#21318
fix(ses): incorrect DKIM records for EmailIdentity#21318mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
Because `route53.determineFullyQualifiedDomainName()` doesn't correctly handles tokens we get the zone name twice here. Another way to solve this would be to fix `determineFullyQualifiedDomainName()`. There is already a discussion there aws#20435 for the hosted zone name part, not the record name. Closes aws#21306
|
|
|
@corymhall FYI Do you think it is better to solve this in See #20435 (comment) |
|
I think that we should fix this in |
I commented on the issue. I agree with @TheRealAmazonKendra, we should address this in route53. |
|
I'm going to go ahead and close this since we won't be moving forward with this particular approach. |
|
@TheRealAmazonKendra if this is fixed under a feature flag in route53 how can it be fixed for everyone in ses? |
|
That's a good point...I guess we need this PR as well, otherwise it will remain broken for anyone that doesn't opt-in to the feature flag. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
☑️ Nothing to doDetails
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
☑️ Nothing to doDetails
|
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Because
route53.determineFullyQualifiedDomainName()doesn't correctlyhandles tokens we get the zone name twice here.
Another way to solve this would be to fix
determineFullyQualifiedDomainName(). There is already a discussionthere #20435 for the hosted zone name
part, not the record name.
Closes #21306
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license