Skip to content

docs(aws-ssm): StringParameter example is wrong#21127

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
josephedward:chore(aws-ssm)-StringParameter-example-is-wrong
Jul 13, 2022
Merged

docs(aws-ssm): StringParameter example is wrong#21127
mergify[bot] merged 1 commit intoaws:mainfrom
josephedward:chore(aws-ssm)-StringParameter-example-is-wrong

Conversation

@josephedward
Copy link
Copy Markdown
Contributor

@josephedward josephedward commented Jul 13, 2022 •
edited by peterwoodworth
Loading

adding indentation as requested by reviewer

fixes #20763

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@josephedward
Update parameter.ts
aa7ae3d 
adding indentation as requested by reviewer
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 13, 2022

@github-actions github-actions bot added the p2 label Jul 13, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 13, 2022 20:22
@josephedward
Copy link
Copy Markdown
Contributor Author

josephedward commented Jul 13, 2022

@peterwoodworth switched to this PR because I hadn't branched in my fork originally - examples are indented, let me know if you need any more edits!

@josephedward josephedward mentioned this pull request Jul 13, 2022
Closed
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 13, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: aa7ae3d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@peterwoodworth peterwoodworth changed the title chore(aws-ssm): StringParameter example is wrong docs(aws-ssm): StringParameter example is wrong Jul 13, 2022
peterwoodworth
peterwoodworth approved these changes Jul 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @josephedward!

@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jul 13, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 13, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8dc083b into aws:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@peterwoodworth peterwoodworth peterwoodworth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ssm: StringParameter example is wrong

3 participants

@josephedward @aws-cdk-automation @peterwoodworth