Skip to content

chore: fix the init task for gitpod#21064

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
pahud:fix-gitpod-init
Jul 14, 2022
Merged

chore: fix the init task for gitpod#21064
mergify[bot] merged 2 commits intoaws:mainfrom
pahud:fix-gitpod-init

Conversation

@pahud
Copy link
Copy Markdown
Contributor

@pahud pahud commented Jul 8, 2022 •
edited
Loading

This PR fixes the init task in .gitpod.yml for gitpod to correctly prebuild and remove the eslint static version pinning.

Fixes: #21063

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 8, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 8, 2022 22:33
@github-actions github-actions bot added the p2 label Jul 8, 2022
@pahud
Copy link
Copy Markdown
Contributor Author

pahud commented Jul 8, 2022

If this PR works, we should be able to click this button and open the prebuilt environment correctly. Let's wait for the 1st prebuild to complete.

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

TheRealAmazonKendra commented Jul 12, 2022

Still a work in progress?

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@pahud
Copy link
Copy Markdown
Contributor Author

pahud commented Jul 14, 2022 •
edited
Loading

Still a work in progress?

It's fine to merge but the prebuild failes to complete. I am afraid ./scripts/foreach.sh yarn build just takes more than one hour, which is the max time limit of the gitpod prebuild(doc) and gitpod might lift this limit in gitpod-io/gitpod#6283

That being said, the prebuild is not gonna work because building everything takes more than 1 hour. When users open the gitpod workspace, it will just automatically kick off the building(you can stop it though).

image

@pahud pahud marked this pull request as ready for review July 14, 2022 15:01
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 14, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bca6d73
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bd53ca4 into aws:main Jul 14, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

Assignees

No one assigned

Labels

p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gitpod not prebuild correctly

3 participants

@pahud @TheRealAmazonKendra @aws-cdk-automation