Skip to content

docs(logs): clarify encryption default for log groups#21060

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
laurelmay:log-group-encryption
Jul 14, 2022
Merged

docs(logs): clarify encryption default for log groups#21060
mergify[bot] merged 2 commits intoaws:mainfrom
laurelmay:log-group-encryption

Conversation

@laurelmay
Copy link
Copy Markdown
Contributor

@laurelmay laurelmay commented Jul 8, 2022

The default encryption for CloudWatch Logs is not performed via a KMS
AWS-managed key which is what is usually implied by "master key".
Updating the documentation to clarify that this is server-side
encryption hopefully clarifies why "KMS key ID" shows as "-" in the
Console for created Log Groups and why the
cloudwatch-log-group-encrypted Config Rule shows as non-compliant.

Based on https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/data-protection.html#encryption-rest


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The default encryption for CloudWatch Logs is not performed via a KMS
AWS-managed key which is what is usually implied by "master key".
Updating the documentation to clarify that this is server-side
encryption hopefully clarifies why "KMS key ID" shows as "-" in the
Console for created Log Groups and why the
`cloudwatch-log-group-encrypted` Config Rule shows as non-compliant.
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 8, 2022

@github-actions github-actions bot added the p2 label Jul 8, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 8, 2022 13:35
@TheRealAmazonKendra TheRealAmazonKendra changed the title docs(logs): Clarify encrpytion default for Log Groups docs(logs): clarify encryption default for log groups Jul 14, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8585ba6 into aws:main Jul 14, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 05815ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants