fix(ecs): ec2Service placement strategies use incorrect casing which causes drift#20946
fix(ecs): ec2Service placement strategies use incorrect casing which causes drift#20946mergify[bot] merged 11 commits intoaws:mainfrom
Conversation
|
|
There was a problem hiding this comment.
It seems we aren't testing this property in any integration tests yet - we should be testing deployment of all properties we set. Could you whip up a quick integration test, or edit an existing one to use this property?
Pull request has been modified.
|
Hey @peterwoodworth Thanks for your response! If you could run the test it would also be greatly appreciated. If you have any questions to my code do not hesitate to ask. I tried orienting myself on other integ tests but didnt really find alot using assertions. |
|
Thanks @tea-418, I'll get to this next week! |
|
Hello @peterwoodworth, i am currently learning about writing tests for this project and would like to attempt writing tests for this. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes #20812
Switches lowercase cpu and memory placement strategy to uppercase as required by cloudformation:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-placementstrategy.html
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license