feat(aws-ec2, aws-eks): allow the use of graviton3 processors#20498
Closed
gergnz wants to merge 4 commits intoaws:masterfrom
Closed
feat(aws-ec2, aws-eks): allow the use of graviton3 processors#20498gergnz wants to merge 4 commits intoaws:masterfrom
gergnz wants to merge 4 commits intoaws:masterfrom
Conversation
|
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
corymhall
suggested changes
May 26, 2022
Contributor
corymhall
left a comment
There was a problem hiding this comment.
@gergnz thanks for your work on this! Just a couple of housekeeping items:
- Can you split this into two PRs (1 for each module)?
- Can you add the new instance type to an existing integration test?
- Can you add a unit test for the eks change?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: allow the use of graviton3, 7th generation processors
utilised existing integration test under aws-ec2
Updated aws-eks and aws-ec2 modules.
fixes: #20482
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license