fix(events-targets): EventBus IAM statements are only added for the first target#20479
Merged
mergify[bot] merged 5 commits intoaws:masterfrom Jun 1, 2022
Merged
fix(events-targets): EventBus IAM statements are only added for the first target#20479mergify[bot] merged 5 commits intoaws:masterfrom
mergify[bot] merged 5 commits intoaws:masterfrom
Conversation
|
|
corymhall
reviewed
May 25, 2022
| this.props.role.addToPrincipalPolicy(this.putEventStatement()); | ||
| } | ||
| const role = this.props.role ?? singletonEventRole(rule, [this.putEventStatement()]); | ||
| const role = this.props.role ?? singletonEventRole(rule, []); |
Contributor
There was a problem hiding this comment.
I wonder if we should change the implementation of singletonEventRole to not take any statements to prevent this from happening in the future.
rix0rrr
approved these changes
Jun 1, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
EventBusconstructor is called with no arguments, then attaching more than a single target to its policy will silently fail to add them. This is because of a strange edge case in the implementation that was not accounted for previously; it is possible forprops.roleto beundefined, yetsingletonEventRole()is still capable of finding the desired role.singletonEventRole()does not add the new statements to any IAM policies that it finds, so as a result adding multiple targets does not add any of them.Fixes #19407.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license