Skip to content

feat(s3): adds objectSizeLessThan property for s3 lifecycle rule#20429

Merged
mergify[bot] merged 8 commits intoaws:masterfrom
daschaa:s3-object-size-less-than
May 31, 2022
Merged

feat(s3): adds objectSizeLessThan property for s3 lifecycle rule#20429
mergify[bot] merged 8 commits intoaws:masterfrom
daschaa:s3-object-size-less-than

Conversation

@daschaa
Copy link
Copy Markdown
Contributor

@daschaa daschaa commented May 19, 2022

Fixes (other half - see #20425) of #20372.
This implements the objectSizeLessThan property for a S3 lifecycle rule.

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented May 19, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 19, 2022 22:31
@github-actions github-actions bot added the p2 label May 19, 2022
comcalvi
comcalvi previously approved these changes May 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mergify mergify bot dismissed comcalvi’s stale review May 24, 2022 23:45

Pull request has been modified.

@daschaa
Copy link
Copy Markdown
Contributor Author

daschaa commented May 25, 2022 •
edited
Loading

Nice work!

@comcalvi Thank you! ❤️
Unfortunately the review was dismissed because of changes. Could you add your review again? Thanks in advance 😊

comcalvi
comcalvi previously approved these changes May 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, made some merge conflicts there. Should be clear now

@mergify mergify bot dismissed comcalvi’s stale review May 25, 2022 15:20

Pull request has been modified.

@daschaa
Copy link
Copy Markdown
Contributor Author

daschaa commented May 26, 2022

@comcalvi I fixed a linting error I accidentally introduced 🫣 Could you review it again please? 😊

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 31, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented May 31, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0f2631f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2bf30df into aws:master May 31, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 31, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@comcalvi comcalvi comcalvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daschaa @aws-cdk-automation @comcalvi