fix(integ-runner): only diff registered stacks#20100
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Apr 27, 2022
corymhall:corymhall/integ-runner/diff-stacks
Merged
fix(integ-runner): only diff registered stacks#20100mergify[bot] merged 3 commits intoaws:masterfrom corymhall:corymhall/integ-runner/diff-stacks
mergify[bot] merged 3 commits intoaws:masterfrom
corymhall:corymhall/integ-runner/diff-stacks
Conversation
Currently the runner will perform a diff of all stacks in the snapshot, not just the stacks that have been "registered" as part of the test case. This PR changes the logic to only perform a diff on stacks that are part of the test case. This will allow us to use separate stacks for things like assertions that will not be part of the diff. As part of this change it was necessary to make some additional changes to the way the runner runs the tests, the main reason being that it is necessary to hold two different versions of the test, the "expected" version and the "actual" version. This PR updates the runner to read the "expected" version of the test from the `integ.json` manifest in the current snapshot and the "actual" version of the test from the changed integ test. Because the legacy tests (those that don't use the `IntegTest` construct) do not create an `integ.json` file, this PR updates the runner to create an `integ.json` file as part of the snapshot creation. This way on the next change the runner is able to read the `integ.json` file from the snapshot to get the "expected" view of the test.
|
|
otaviomacedo
approved these changes
Apr 27, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the runner will perform a diff of all stacks in the snapshot,
not just the stacks that have been "registered" as part of the test
case. This PR changes the logic to only perform a diff on stacks that
are part of the test case. This will allow us to use separate stacks for
things like assertions that will not be part of the diff.
As part of this change it was necessary to make some additional changes
to the way the runner runs the tests, the main reason being that it is
necessary to hold two different versions of the test, the "expected"
version and the "actual" version.
This PR updates the runner to read the "expected" version of the test
from the
integ.jsonmanifest in the current snapshot and the "actual"version of the test from the changed integ test. Because the legacy
tests (those that don't use the
IntegTestconstruct) do not create aninteg.jsonfile, this PR updates the runner to create aninteg.jsonfile as part of the snapshot creation. This way on the next change the
runner is able to read the
integ.jsonfile from the snapshot to getthe "expected" view of the test.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license