I think the most interesting part of this PR is how to handle the policy property of IBucket in the fromCfnBucket() method.

Since it's the Policy that has the reference to the Bucket, and not the other way round, I've decided to not fill this property in fromCfnBucket() at all. Instead, I've introduced a similar method in BucketPolicy, fromCfnBucketPolicy(), and I find the Bucket that the Policy is referencing, and I fill the new bucket property that I've added to BucketPolicy. Of course, fromCfnBucketPolicy() calls fromCfnBucket() in its implementation.

I'm curious on the opinion of this solution. I could be convinced that we need to pass some sort of optional "template" property as the second argument to fromCfnBucket() which allows the code to search the template for all Bucket Policies that reference the given Bucket, and our CfnInclude class would implement this "template" interface.

Let me know what you think @rix0rrr!

To others, who might come across this PR, I am resolving the conflicts and making sure the tests pass.

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 92cfc18
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).