fix(imagebuilder): AmiDistributionConfiguration renders empty#20045
Merged
mergify[bot] merged 1 commit intomasterfrom Apr 22, 2022
Merged
fix(imagebuilder): AmiDistributionConfiguration renders empty#20045mergify[bot] merged 1 commit intomasterfrom
mergify[bot] merged 1 commit intomasterfrom
Conversation
Certain fields of the `ImageBuilder` service used to be typed as `Json` (i.e., arbitrary data). - In TypeScript, you would pass that data as an object literal with *capitalized* properties. - In Python, you would pass it as a `dict` - In Java, you would pass it as a `HashMap` - etc In the new CloudFormation spec, it is now typed as a struct. This adds type information that didn't use to be there. CDK now generates classes for it. - In TypeScript, you must now pass an object literal with *lowercased* properties. - In Python, you must now pass it as an instance of a class. - In Java, you must now use a builder to construct the object. Because of this, adding types to properties is a breaking change to the L1 layer. If you don't pass the information correctly, an empty object comes out the other end, probably not rendering what you expected. This is disastrous for construct libraries that are using L1s, as they are not in control when users upgrade their libraries but they may all of a sudden be broken with no recourse. Case in point: [ParallelCluster3](https://github.com/aws/aws-parallelcluster)
|
|
MrArnoldPalmer
approved these changes
Apr 22, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain fields of the
ImageBuilderservice used to be typed asJson(i.e., arbitrary data).capitalized properties.
dictHashMapIn the new CloudFormation spec, it is now typed as a struct. This
adds type information that didn't use to be there. CDK now generates
classes for it.
lowercased properties.
Because of this, adding types to properties is a breaking change to the
L1 layer. If you don't pass the information correctly, an empty object
comes out the other end, probably not rendering what you expected.
This is disastrous for construct libraries that are using L1s, as they
are not in control when users upgrade their libraries but they may all
of a sudden be broken with no recourse. Case in point:
ParallelCluster3
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license