Skip to content

chore: minor test improvements#20035

Merged
mergify[bot] merged 5 commits intomasterfrom
huijbers/test-stuff
Apr 27, 2022
Merged

chore: minor test improvements#20035
mergify[bot] merged 5 commits intomasterfrom
huijbers/test-stuff

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Apr 22, 2022

  • Remove gross duplication in a test
  • Have objectMatcher tell us what keys ARE there instead of just what
    keys AREN'T there
  • Add a test to confirm that addEventSourceMapping() doesn't
    accidentally produce non-stable logical IDs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
chore: minor test improvements
51ead16 
- Remove gross duplication in a test
- Have objectMatcher tell us what keys ARE there instead of just what
  keys AREN'T there
- Add a test to confirm that `addEventSourceMapping()` doesn't
  accidentally produce non-stable logical IDs
@rix0rrr rix0rrr requested a review from a team April 22, 2022 13:28
@rix0rrr rix0rrr self-assigned this Apr 22, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Apr 22, 2022

@github-actions github-actions bot added the p2 label Apr 22, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 22, 2022 13:28
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 22, 2022
kaizencc
kaizencc approved these changes Apr 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ew! Thanks for fixing. Approved, but you're gonna have to fix a few of the assertion tests.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 27, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 27, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 27, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b7b2a54
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8bd6c59 into master Apr 27, 2022
@mergify mergify bot deleted the huijbers/test-stuff branch April 27, 2022 10:38
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 27, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

@rix0rrr rix0rrr

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rix0rrr @aws-cdk-automation @kaizencc