feat(rds): allow DatabaseClusterFromSnapshot to set copyTagsToSnapshot property#19932
feat(rds): allow DatabaseClusterFromSnapshot to set copyTagsToSnapshot property#19932mergify[bot] merged 13 commits intoaws:masterfrom AnuragMohapatra:feat(aws-rds)-MoveCopyTagsToSnapshotToBaseProps
DatabaseClusterFromSnapshot to set copyTagsToSnapshot property#19932Conversation
|
|
…ps://github.com/AnuragMohapatra/aws-cdk into feat(aws-rds)-MoveCopyTagsToSnapshotToBaseProps
skinny85
left a comment
There was a problem hiding this comment.
Thanks for the contribution @AnuragMohapatra! A few small comments.
| // Encryption | ||
| kmsKeyId: props.storageEncryptionKey?.keyArn, | ||
| storageEncrypted: props.storageEncryptionKey ? true : props.storageEncrypted, | ||
| //Tag |
There was a problem hiding this comment.
| //Tag | |
| // Tags |
DatabaseClusterFromSnapshot to set copyTagsToSnapshot property
|
Thanks @skinny85 for reviewing, I have updated the changes as per suggestions. |
skinny85
left a comment
There was a problem hiding this comment.
Thanks for the contribution @AnuragMohapatra!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This change will now allow users to set
copyTagsToSnapshotattribute for theDatabaseClusterFromSnapshot.This will now be consistent with the way the database instance works.
Integration test may not be possible since this requires a valid snapshot to pre-exist before building the CDK stack to generate the CDK local snapshot.
It might be possible to add a snapshot first by creating a new DB Cluster taking a manual snapshot then using that in
DatabaseClusterFromSnapshotbut it will become a hassle for anyone else in future to maintain or update since they will always need to proceed in the same manner to get the exact snapshot.An integration test for
copyTagsToSnapshotalready exists forDatabaseClusterininteg.cluster.jswhich is passing successfully on executing the tests.Closes #19884
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license