Skip to content

docs(aws-cdk-lib): update README to reference DependencyGroup instead…#19520

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
madeline-k:docs/19352
Aug 3, 2022
Merged

docs(aws-cdk-lib): update README to reference DependencyGroup instead…#19520
mergify[bot] merged 8 commits intoaws:mainfrom
madeline-k:docs/19352

Conversation

@madeline-k
Copy link
Copy Markdown
Contributor

… of ConcreteDependable

Closes #19352


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@madeline-k madeline-k requested review from a team and rix0rrr March 22, 2022 23:45
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Mar 22, 2022

@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Mar 22, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 22, 2022
@madeline-k madeline-k removed their assignment Mar 22, 2022
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the build failure -- perhaps we should target this readme update to v2-main rather than master? It looks like pkglint is complaining about the core readmes being out of sync.

@madeline-k madeline-k changed the base branch from master to v2-main March 23, 2022 17:34
@madeline-k
Copy link
Copy Markdown
Contributor Author

Good call, @kaizen3031593 I switched to v2. Hopefully this works. It's a bit weird because the rosetta dir for aws-cdk-lib is generated from the core one, so that's why I still need to modify it there.

@TheRealAmazonKendra
Copy link
Copy Markdown
Contributor

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 28, 2022

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 3, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7cf2f13
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ecff7bd into aws:main Aug 3, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 3, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-cdk-lib Related to the aws-cdk-lib package contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-cdk-lib): ReadMe Overview contains example using (removed) ConcreteDependable

5 participants