@rix0rrr we should probably discuss this before graduating this module. We should have a more stringent process for graduating construct libraries. @arcrank stay tuned :).

I noticed for some older PRs that there was a checklist included that had items like no p0 bugs in past 4 weeks, cleared lint exceptions etc.. If you have a current one for that we can go over it since I'm not sure if all of that will apply.

We've already reviewed our APIs internally and have no plans for any behavior change in our Cfn Handlers either.

Want to circle back on this. We had review. There were two takeaways I had

1. Minor doc nits/updates. These were addressed and merged in
2. Ideas around adding default policies on sharing a portfolio. I went back to our team and PMs to understand usage a little better and I think that for now, we don't see value in adding some limited subset of resource policies to shared users. Read only permissions are not very helpful or useful, and due to how we make our own ids for provisioning users require some wildcard permissions to actually provision a product.

I understand that the CDK convention of grantRead and automatically adding some base policy statements, but this is not the same mechanism (hence why we also don't name it grantRead so as not to confuse people).

The constrainTagUpdates API is still confusing to me (call constrain -> actually means "allow"). Maybe the same is true for other APIs. Can you find a synonym for that? configure maybe?

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: b91cdef
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).