chore(cli): integ test filtering is broken#19462
Merged
mergify[bot] merged 2 commits intomasterfrom Mar 21, 2022
Merged
Conversation
Turns out that Jest's `test.concurrent()` does not play well when running `jest -t TESTNAME`: jest will actually start all tests, not just the one you were trying to run. Reported here: jestjs/jest#12588 We used to have something to opt-out of concurrent running: we have to flip that around, and opt in to concurrent running only for the canary and pipeline tests, where we *know* for a fact we're not filtering.
|
|
Contributor
Author
|
Should not be merged before https://github.com/cdklabs/cdk-ops/pull/1954 has been merged. |
RomainMuller
approved these changes
Mar 18, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that Jest's
test.concurrent()does not play well whenrunning
jest -t TESTNAME: jest will actually start all tests,not just the one you were trying to run.
Reported here: jestjs/jest#12588
We used to have something to opt-out of concurrent running: we
have to flip that around, and opt in to concurrent running only
for the canary and pipeline tests, where we know for a fact
we're not filtering.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license