chore: allow opt-out of test.concurrent in integ tests#19402
Merged
mergify[bot] merged 2 commits intomasterfrom Mar 15, 2022
Merged
chore: allow opt-out of test.concurrent in integ tests#19402mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
The `test.concurrent` feature of `jest` immediately executes the test code in order to obtain a `Promise` that is checked as part of the test run. This means that the test handler code runs whether the test is included or not in the assessment, as controlled by the `-t` flag of jest. In order to allow integration tests to selectively run only a subset of the tests, we must hence not use `test.concurrent`, or else all test handlers run fully, leading to unwanted side effects. This is needed in order to be able to complete cdklabs/cdk-ops#1922.
|
|
iliapolo
reviewed
Mar 15, 2022
| "lib/init-templates/**/typescript/**/*.ts" | ||
| ] | ||
| ], | ||
| "references": [ |
Contributor
Author
There was a problem hiding this comment.
I wrote those. They were missing. They made my DX better :)
Co-authored-by: Eli Polonsky <epolon@amazon.com>
iliapolo
approved these changes
Mar 15, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test.concurrentfeature ofjestimmediately executes the testcode in order to obtain a
Promisethat is checked as part of the testrun.
This means that the test handler code runs whether the test is included
or not in the assessment, as controlled by the
-tflag of jest.In order to allow integration tests to selectively run only a subset of
the tests, we must hence not use
test.concurrent, or else all testhandlers run fully, leading to unwanted side effects.
This is needed in order to be able to complete cdklabs/cdk-ops#1922.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license