build: update verify-imports-resolve-same to ignore module extensions#19096
Merged
mergify[bot] merged 1 commit intoaws:masterfrom Feb 22, 2022
Merged
build: update verify-imports-resolve-same to ignore module extensions#19096mergify[bot] merged 1 commit intoaws:masterfrom
mergify[bot] merged 1 commit intoaws:masterfrom
Conversation
…ensions verify-imports-resolve-same.ts script validates if the package import for monorepo package imports the same modules, but when validating the imports typescript either would provide .d.ts or .ts or .js file based on how it is imported. Since .ts and .d.ts are typescript artifacts and .js is used at runtime the extension can be safely ignored. The code to ignore the extension was not escaping the `.` char and string replacement was failing because of it. Update the regex to escape `.`
|
|
skinny85
approved these changes
Feb 22, 2022
|
|
||
| // Return the filename | ||
| const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/.ts|.js|.d.ts/, ''); | ||
| const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/[.](ts|js|d\.ts)$/, ''); |
Contributor
There was a problem hiding this comment.
Let's maybe also escape the first . here, instead of using a one-element class, since we do that later in the regex anyway, so it's better to be consistent...?
Suggested change
| const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/[.](ts|js|d\.ts)$/, ''); | |
| const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/\.(ts|js|d\.ts)$/, ''); |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify-imports-resolve-same.ts script validates if the package import for
monorepo package imports the same modules, but when validating the imports
typescript either would provide .d.ts or .ts or .js file based on how it is
imported. Since .ts and .d.ts are typescript artifacts and .js is used at
runtime the extension can be safely ignored. The code to ignore the extension
was not escaping the
.char and string replacement was failing because of it.Update the regex to escape
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license