Skip to content

chore: mocking the version number to make the tests deterministic#19089

Merged
mergify[bot] merged 1 commit intomasterfrom
otaviom/mock-version-notices
Feb 22, 2022
Merged

chore: mocking the version number to make the tests deterministic#19089
mergify[bot] merged 1 commit intomasterfrom
otaviom/mock-version-notices

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

Because the actual version of the CLI depends on the context ("0.0.0" on the dev environment, actual version on the pipeline etc), we have to mock the return value of the function to make the tests deterministic.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 22, 2022

@otaviomacedo otaviomacedo requested review from a team and kaizencc February 22, 2022 13:59
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Feb 22, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 22, 2022
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 50b298c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 22, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d325004 into master Feb 22, 2022
@mergify mergify bot deleted the otaviom/mock-version-notices branch February 22, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants