fix(aws-apigateway): api gateway usage plan#19023
fix(aws-apigateway): api gateway usage plan#19023mergify[bot] merged 6 commits intoaws:masterfrom HariboDev:master
Conversation
peterwoodworth
left a comment
There was a problem hiding this comment.
Thanks for the contribution @HariboDev,
While this looks like it works great, I'm a little doubtful that the validateDouble method you've created is necessary. I imagine the purpose of the validateInteger method was to protect specifically against doubles, since typing should prevent any non-numbers from showing up in the first place.
What do you think?
|
I added this method as the original
I think both methods are needed as, according to the documentation, burst limits must be integers and rate limits can be either decimals or integers. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
API Gateway allows decimals and integers for rate limits. This PR fixes an error thrown when entering a decimal.
To fix this, I created a new method
validateDouble()inutils.tsbased offvalidateInteger()and updated the caller as seen in the commit.This also fixes #18994.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license