fix(custom-resources): physical resource id must be determined before isComplete#18630
Merged
mergify[bot] merged 3 commits intoaws:masterfrom Feb 26, 2022
pflorek:fix/set-actual-physical-resource-id-on-is-complete
Merged
fix(custom-resources): physical resource id must be determined before isComplete#18630mergify[bot] merged 3 commits intoaws:masterfrom pflorek:fix/set-actual-physical-resource-id-on-is-complete
mergify[bot] merged 3 commits intoaws:masterfrom
pflorek:fix/set-actual-physical-resource-id-on-is-complete
Conversation
|
|
Set the actual physical resource id of an asynchronous operation, when the waiter is finished with isComplete: true
rix0rrr
approved these changes
Feb 26, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Author
|
@rix0rrr Thank you!!! 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some resource on event can only generate an intermediary physical resource id. On isComplete the actual physical resource id can be retrieved from the created resource. Therefor it's useful to override the temporary one.
Fixes #18670
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license