Skip to content

chore(cloudtrail): enforceSSL on trail s3 bucket#18270

Merged
mergify[bot] merged 9 commits intoaws:masterfrom
PatMyron:patch-5
Jan 24, 2022
Merged

chore(cloudtrail): enforceSSL on trail s3 bucket#18270
mergify[bot] merged 9 commits intoaws:masterfrom
PatMyron:patch-5

Conversation

@PatMyron
Copy link
Copy Markdown
Contributor

@PatMyron PatMyron commented Jan 5, 2022 •
edited
Loading

#18283

could pass another bucket, but automatically created buckets are convenient/popular, so worth improving defaults

https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-cloudtrail.Trail.html
https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.Bucket.html

# updated integ snapshots
packages/@aws-cdk/aws-cloudtrail $ /workspace/aws-cdk/tools/\@aws-cdk/cdk-integ-tools/bin/cdk-integ --dry-run
packages/@aws-cdk/aws-codepipeline-actions $ /workspace/aws-cdk/tools/\@aws-cdk/cdk-integ-tools/bin/cdk-integ --dry-run
# eslint fix
/workspace/aws-cdk/node_modules/eslint/bin/eslint.js packages/@aws-cdk/aws-cloudtrail/test/ --ext=.ts --fix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@comcalvi comcalvi comcalvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@comcalvi comcalvi

Labels

@aws-cdk/aws-cloudtrail Related to AWS CloudTrail

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PatMyron @aws-cdk-automation @comcalvi