fix(ecr): setting imageScanningConfiguration to false does nothing on existing repository#18078
Conversation
|
|
|
Will push successful integ tests today |
madeline-k
left a comment
There was a problem hiding this comment.
I am always a little bit nervous about changes that change the generated template with no changes to CDK app code. But in this case it seems necessary. This will fix an upgrade scenario that is currently broken. And, this should not cause anyone to have their stacks in a broken state after upgrade and cdk deploy.
Thanks, @peterwoodworth!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… existing repository
4cc6b9d to
2de17ee
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
fixes #18077
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license