feat(backup): support RDS database cluster and serverless cluster#17971
feat(backup): support RDS database cluster and serverless cluster#17971mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
|
|
| if (node instanceof rds.CfnDBInstance) { | ||
| const dbInstance = node as rds.CfnDBInstance; | ||
| if (!dbInstance.dbClusterIdentifier) { | ||
| this.resources.push(Stack.of(node).formatArn({ | ||
| service: 'rds', | ||
| resource: 'db', | ||
| arnFormat: ArnFormat.COLON_RESOURCE_NAME, | ||
| resourceName: node.ref, | ||
| })); | ||
| } | ||
| } |
There was a problem hiding this comment.
If this change is correct: Can we just change it? Or do we have to treat it as a breaking change and create a feature flag? (I feel more confident when we create a feature flag.)
|
I've marked this as |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add methods
fromRdsDatabaseClusterandfromRdsServerlessClusterto support RDS database cluster and serverless cluster in AWS Backup. InBackupableResourcesCollector,CfnDBClusterwill be detected and added to the backup selection.Missing unit tests for
fromRdsDatabaseInstancewere added as well.Change behaviour of
CfnDBInstanceinBackupableResourcesCollector. Database instances will be added only if attributedbClusterIdentifieris not set. In the current implementation, database instances of a database cluster will be added to the backup selection. In my point of view, it is not necessary to backup each database instance of a database cluster if the database cluster is selected. Please check if this change is correct and allowed.Closes #16457.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license