fix(ecs): cannot use tokens for certain props#17106
Closed
peterwoodworth wants to merge 4 commits intoaws:masterfrom
peterwoodworth:token-patch-1
Closed
fix(ecs): cannot use tokens for certain props#17106peterwoodworth wants to merge 4 commits intoaws:masterfrom peterwoodworth:token-patch-1
peterwoodworth wants to merge 4 commits intoaws:masterfrom
peterwoodworth:token-patch-1
Conversation
|
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
madeline-k
suggested changes
Feb 16, 2022
Contributor
madeline-k
left a comment
There was a problem hiding this comment.
Looks great, I think we should just add one more test. Thanks, @peterwoodworth!
| this.cluster = props.cluster || this.getDefaultCluster(this, props.vpc); | ||
|
|
||
| if (props.desiredCount !== undefined && props.desiredCount < 1) { | ||
| if (props.desiredCount !== undefined && !cdk.Token.isUnresolved(props.desiredCount) && props.desiredCount < 1) { |
Contributor
There was a problem hiding this comment.
Can you add a test for this one as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16648
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license