chore: remove nodeunit from the repo and support for it in cdk-build#16596
Merged
mergify[bot] merged 8 commits intomasterfrom Sep 22, 2021
Merged
chore: remove nodeunit from the repo and support for it in cdk-build#16596mergify[bot] merged 8 commits intomasterfrom
mergify[bot] merged 8 commits intomasterfrom
Conversation
|
|
added 2 commits
September 22, 2021 12:30
njlynch
approved these changes
Sep 22, 2021
Contributor
njlynch
left a comment
There was a problem hiding this comment.
Two minor nitpicks; otherwise looks good!
| "cdk-build": { | ||
| "jest": true | ||
| }, | ||
| "cdk-build": {}, |
Contributor
There was a problem hiding this comment.
If we no longer have/need any config for "cdk-build", can we just remove this entirely? (Same throughout).
Contributor
There was a problem hiding this comment.
I believe that this change may have something to do with the build failure in aws-cdk-lib.
aws-cdk-lib: An error occurred: TypeError: Cannot read property 'cloudformation' of undefined
added 2 commits
September 22, 2021 14:58
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that all modules are in
jest, removenodeunitand@types/nodeuniteverywhere.Finally, remove remove support for nodeunit in cdk-build.
This means that the special "jest" flag is no longer required
in the "cdk-build" section of
package.json.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license