chore(aws-cdk): correct construct-versions for v2 init templates#16578
Merged
mergify[bot] merged 3 commits intomasterfrom Sep 21, 2021
Merged
chore(aws-cdk): correct construct-versions for v2 init templates#16578mergify[bot] merged 3 commits intomasterfrom
mergify[bot] merged 3 commits intomasterfrom
Conversation
When the constructs compatibility layer was removed on the v2 branch (#12054), a change was made to the init templates to support a flexible constructs version (either ^3 or ^10). These changes were never back-ported to v1, leading to the situation where there are (unnecessary) differences on the v2 templates between the v1 and v2 branches. Backported these changes manually (for package.json and init.ts), and then by diffing the init templates directory between master and v2-main.
|
|
rix0rrr
approved these changes
Sep 21, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the constructs compatibility layer was removed on the v2 branch (#12054), a
change was made to the init templates to support a flexible constructs version
(either ^3 or ^10). These changes were never back-ported to v1, leading to the
situation where there are (unnecessary) differences on the v2 templates between
the v1 and v2 branches.
Backported these changes manually (for package.json and init.ts), and then by
diffing the init templates directory between master and v2-main.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license