Skip to content

fix(route53resolver): FirewallDomainList throws with wildcard domains#16538

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
jogold:route53resolver-wildcard-domain
Sep 21, 2021
Merged

fix(route53resolver): FirewallDomainList throws with wildcard domains#16538
mergify[bot] merged 3 commits intoaws:masterfrom
jogold:route53resolver-wildcard-domain

Conversation

@jogold
Copy link
Copy Markdown
Contributor

@jogold jogold commented Sep 18, 2021

Closes #16527


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 18, 2021

@njlynch njlynch changed the title fix(rout53resolver): FirewallDomainList throws with wildcard domains fix(route53resolver): FirewallDomainList throws with wildcard domains Sep 21, 2021
Copy link
Copy Markdown
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @jogold

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 04cc299
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 643e5ee into aws:master Sep 21, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-route53resolver): FirewallDomains.fromList() does not support wildcard subdomains

3 participants