Skip to content

chore: add missing "build" script in the individual-packages module#16507

Merged
mergify[bot] merged 4 commits intoaws:masterfrom
hassanazharkhan:chore/add-missing-scripts-individual-package
Sep 21, 2021
Merged

chore: add missing "build" script in the individual-packages module#16507
mergify[bot] merged 4 commits intoaws:masterfrom
hassanazharkhan:chore/add-missing-scripts-individual-package

Conversation

@hassanazharkhan
Copy link
Copy Markdown
Contributor

@hassanazharkhan hassanazharkhan commented Sep 16, 2021

scripts/foreach.sh yarn build was not working due to missing command in individual-package.

scripts/foreach.sh yarn build is mentioned in the 'Contributing' guide.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 16, 2021

@skinny85 skinny85 changed the title chore: Added missing script "build" in individual-package chore: add missing "build" script in the individual-packages module Sep 16, 2021
@skinny85 skinny85 requested a review from njlynch September 16, 2021 00:15
njlynch
njlynch previously approved these changes Sep 21, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed njlynch’s stale review September 21, 2021 15:56

Pull request has been modified.

@hassanazharkhan
Copy link
Copy Markdown
Contributor Author

@njlynch Can you please re-approve?

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c014681
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 44a5e24 into aws:master Sep 21, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants