Skip to content

feat(assertions): match into serialized json#16456

Merged
mergify[bot] merged 8 commits intomasterfrom
nija-at/assertions-serializedjson
Sep 13, 2021
Merged

feat(assertions): match into serialized json#16456
mergify[bot] merged 8 commits intomasterfrom
nija-at/assertions-serializedjson

Conversation

@nija-at
Copy link
Copy Markdown
Contributor

@nija-at nija-at commented Sep 10, 2021

Introduce Match.serializedJson() that can parse JSON serialized as a
string, and continue matching into the parsed JSON.

Migrate the rest of the tests in the pipelines module.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested review from a team and rix0rrr September 10, 2021 15:45
@nija-at nija-at self-assigned this Sep 10, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 10, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 10, 2021
@nija-at nija-at force-pushed the nija-at/assertions-serializedjson branch from 42d7e70 to 6f74e3d Compare September 10, 2021 15:46
@nija-at nija-at force-pushed the nija-at/assertions-serializedjson branch from 6f74e3d to fc5cc31 Compare September 10, 2021 15:47
@nija-at nija-at requested a review from a team September 12, 2021 14:47
@nija-at nija-at force-pushed the nija-at/assertions-serializedjson branch from eecc4e0 to d78bd67 Compare September 13, 2021 08:18
@nija-at nija-at dismissed BenChaimberg’s stale review September 13, 2021 08:18

Addressed comments

@nija-at nija-at requested review from a team and BenChaimberg September 13, 2021 08:19
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 845c118
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fed30fc into master Sep 13, 2021
@mergify mergify bot deleted the nija-at/assertions-serializedjson branch September 13, 2021 13:23
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants