feat(pipelines): ECR source action #16385
feat(pipelines): ECR source action #16385mergify[bot] merged 9 commits intoaws:masterfrom alexpulver:pipelines-ecr-source
Conversation
|
|
|
I will need to rework the |
Pull request has been modified.
|
@rix0rrr I changed the code to handle the No namespace: {
"Resources": {
"Repository22E53BBD": {
"Type": "AWS::ECR::Repository"
},
<snip>With namespace: {
"Resources": {
"Repository22E53BBD": {
"Type": "AWS::ECR::Repository",
"Properties": {
"RepositoryName": "namespace/repo"
}
},
<snip>Pipeline: {
"Resources": {
<snip>
"Pipeline9850B417": {
"Type": "AWS::CodePipeline::Pipeline",
"Properties": {
"RoleArn": {
"Fn::GetAtt": [
"PipelineRoleB27FAA37",
"Arn"
]
},
"Stages": [
{
"Actions": [
{
"InputArtifacts": [],
"ActionTypeId": {
"Version": "1",
"Owner": "AWS",
"Category": "Source",
"Provider": "ECR"
},
"OutputArtifacts": [
{
"Name": "Source"
}
],
"RunOrder": 1,
"Configuration": {
"ImageTag": "latest",
"RepositoryName": {
"Ref": "Repository22E53BBD"
}
},
"Name": {
"Fn::Join": [
"_",
{
"Fn::Split": [
"/",
{
"Ref": "Repository22E53BBD"
}
]
}
]
}
}
],
"Name": "Source"
},
<snip> |
|
@rix0rrr would be glad to have your input on the above |
924c117 to
ebfd5f2
Compare
| * const bucket: IBucket = ... | ||
| * CodePipelineSource.s3(bucket, { | ||
| * key: 'path/to/file.zip', | ||
| * import * as ecr from '@aws-cdk/aws-ecr'; |
There was a problem hiding this comment.
@alexpulver : should the following comments have been modified ? I think they still apply to the s3 factory method.
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #16378
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license