fix(cloudwatch): cross account alarms does not support math expressions#16333
Merged
mergify[bot] merged 8 commits intoaws:masterfrom Sep 7, 2021
kaizencc:math-expressions
Merged
fix(cloudwatch): cross account alarms does not support math expressions#16333mergify[bot] merged 8 commits intoaws:masterfrom kaizencc:math-expressions
mergify[bot] merged 8 commits intoaws:masterfrom
kaizencc:math-expressions
Conversation
|
|
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
madeline-k
reviewed
Sep 1, 2021
Contributor
Author
|
I have confirmed via symlink that this fix deploys as expected in my AWS account. |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now they do. Closes #16331.
I have also modified the comment to explain
returnData: entry.tag ? undefined : falsebut I endeavor to explain even more here. Only 1 metric within an expression can havereturnData = true; the rest must befalse. Cloudformation also defaults an undefined return data totrueas long as the rest are set tofalse, which is why this ternary operation works. The idea behind this line is thatentry.tagis defined (with a default oftrue) for the top level expression only and thus every other metric within the expression hasreturnData = false.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license