feat(backup): option to prevent recovery point deletions#16282
feat(backup): option to prevent recovery point deletions#16282mergify[bot] merged 7 commits intoaws:masterfrom
Conversation
Add a convenience `BackupVault.DENY_DELETE_RECOVERY_POINT` policy to prevent recovery point deletions. Converted test to use `assertions` while in there.
|
|
BenChaimberg
left a comment
There was a problem hiding this comment.
Thanks for adding this! I think it's a very helpful configuration to have around but I'd like it to be a bit more discoverable – currently, users need to "know" about the static property and also know that they need to provide it to the accessPolicy property. What do you think about making this a bit more visible by adding a property to BackupProps? Maybe something like blockRecoveryPointDeletion?: boolean?
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Add a
blockRecoveryPointDeletionprop that add statements tothe vault access policy that prevents recovery point deletions.
Converted test to use
assertionswhile in there.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license