fix(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name#16150
Merged
mergify[bot] merged 4 commits intoaws:masterfrom Sep 8, 2021
kaizencc:cli-error
Merged
fix(cli): 'deploy' and 'diff' silently does nothing when given unknown stack name#16150mergify[bot] merged 4 commits intoaws:masterfrom kaizencc:cli-error
mergify[bot] merged 4 commits intoaws:masterfrom
kaizencc:cli-error
Conversation
|
|
rix0rrr
approved these changes
Sep 8, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second attempt as last PR failed integration tests
Currently,
cdk deployandcdk diffon stacks that do not exist return no output on the command line. This PR introduces a descriptive error message for those cases so it is easier to understand what happened.The behavior of the error is that if you specify a stack or stacks, the CLI expects to match at least one known stack. If the CLI cannot find a matching stack, the error is thrown. However, if you specify multiple stacks (i.e.
cdk deploy ThisStackExists ThisStackDoesnt) and one of those stacks do not match, the CLI will silently ignore the request to deployThisStackDoesntwithout throwing an error.closes #15866 while adding the same idea to
diffas well asdeploy.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license