Skip to content

chore: using the function parameter instead of '.' to find the folders#16132

Merged
mergify[bot] merged 1 commit intoaws:v2-mainfrom
otaviomacedo:symlink-path-variable
Aug 19, 2021
Merged

chore: using the function parameter instead of '.' to find the folders#16132
mergify[bot] merged 1 commit intoaws:v2-mainfrom
otaviomacedo:symlink-path-variable

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

@otaviomacedo otaviomacedo commented Aug 19, 2021

Both parameters to find (the folder to where the search is restricted and what patterns to exclude) should be given by the function parameter, to make sure that they refer to the same folder. Otherwise, we can get errors like ln: <folder name>: Operation not permitted.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@otaviomacedo otaviomacedo requested a review from rix0rrr August 19, 2021 14:17
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 19, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 19, 2021
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 55e2468
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ceab896 into aws:v2-main Aug 19, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants