chore(ec2): deprecate security group name accessor#16116
chore(ec2): deprecate security group name accessor#16116mergify[bot] merged 9 commits intoaws:masterfrom mprencipe:fix-13774
Conversation
|
|
njlynch
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I absolutely agree we should deprecate the property, given how misleading it is. However, I disagree with the suggestion in the issue that we should make it throw. There is a chance that folks have built apps using this field (albeit incorrectly), and the change to make it throw would break them. While logically a small change, it's still a breaking change. I'd prefer we simply deprecate, which will cause it to be removed in the next major version (CDKv2).
Pull request has been modified.
|
Hi, thanks for the comment. By making the accessor throw, I was following the advice in the issue:
|
Pull request has been modified.
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The security group name accessor will (almost) always return the security group ID, rather than the name. This change deprecates the name accessor to make it clearer to users that this is not a supported use case.
fixes #13774
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license