Skip to content

feat(lambda): configure workdir for docker image based functions#16111

Merged
mergify[bot] merged 7 commits intoaws:masterfrom
blaenk:lambda-image-workdir
Sep 14, 2021
Merged

feat(lambda): configure workdir for docker image based functions#16111
mergify[bot] merged 7 commits intoaws:masterfrom
blaenk:lambda-image-workdir

Conversation

@blaenk
Copy link
Copy Markdown
Contributor

@blaenk blaenk commented Aug 18, 2021

CloudFormation allows setting the WorkingDirectory property in AWS::Lambda::Function.ImageConfig to override the docker container's working directory, but this isn't currently exposed through CDK. Not sure if that was intentional.

This PR wires that up.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 18, 2021

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 18, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@blaenk blaenk changed the title Allow setting lambda docker image WorkingDirectory feat(lambda): Allow setting lambda docker image WorkingDirectory Aug 18, 2021
@blaenk
Copy link
Copy Markdown
Contributor Author

blaenk commented Aug 18, 2021

PR Linter / validate-pr (pull_request):

Error: Features must contain a change to a README file

Which? It seems the readme already doesn't cover the other properties like entryPoint (they're instead documented in the auto-generated docs).

Would this qualify as a fix instead then since it's adding a property that wasn't previously exposed?

@peterwoodworth peterwoodworth added @aws-cdk/aws-lambda Related to AWS Lambda effort/small Small work item – less than a day of effort labels Aug 19, 2021
@nija-at nija-at changed the title feat(lambda): Allow setting lambda docker image WorkingDirectory feat(lambda): configure workdir for docker image based functions Aug 24, 2021
nija-at
nija-at previously approved these changes Aug 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. Looks great!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed nija-at’s stale review September 4, 2021 04:20

Pull request has been modified.

@blaenk blaenk requested a review from nija-at September 4, 2021 05:01
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 14, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: dafed60
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b3eafc2 into aws:master Sep 14, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nija-at nija-at nija-at approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nija-at nija-at

Labels

@aws-cdk/aws-lambda Related to AWS Lambda effort/small Small work item – less than a day of effort

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blaenk @aws-cdk-automation @nija-at @peterwoodworth