Skip to content

fix(autoscaling): EbsDeviceVolumeType.IO2 is not a valid CloudFormation value#16028

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
jumic:autoscaling-volumetype-io2
Sep 7, 2021
Merged

fix(autoscaling): EbsDeviceVolumeType.IO2 is not a valid CloudFormation value#16028
mergify[bot] merged 3 commits intoaws:masterfrom
jumic:autoscaling-volumetype-io2

Conversation

@jumic
Copy link
Copy Markdown
Contributor

@jumic jumic commented Aug 12, 2021

Remove value IO2 from enum EbsDeviceVolumeType because it is not supported in CloudFormation.

Fixes #16027.

Please double-check before approving: Value from enum is removed which could potentially be a breaking change. However, it's an invalid value. Therefore, it should be correct to remove it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 12, 2021

@jumic
Copy link
Copy Markdown
Contributor Author

jumic commented Aug 12, 2021 •
edited
Loading

PR Linter failed with "Fixes must contain a change to a test file". Could we skip this for this issue? I think there is no test case that makes sense here.

@peterwoodworth
Copy link
Copy Markdown
Contributor

peterwoodworth commented Aug 12, 2021

Thanks! But closing for reason mentioned in the issue

@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling labels Aug 13, 2021
@peterwoodworth
Copy link
Copy Markdown
Contributor

peterwoodworth commented Aug 13, 2021

Looks like the build is failing.

@rix0rrr I'll leave this issue to you. tl;dr PR #12074 created the io2 option in ec2's and Autoscaling's enums EbsDeviceVolumeType, however this only should have been created in the ec2 enum because io2 isn't supported for autoscaling.

@peterwoodworth peterwoodworth added the pr-linter/exempt-test The PR linter will not require test changes label Aug 13, 2021
@jumic
Copy link
Copy Markdown
Contributor Author

jumic commented Aug 15, 2021

I fixed the build by adding the change to the breaking changes file.
Do I also have to declare this PR as a breaking change? From a technical point of view, it is a breaking change, because the value will be removed. However, this value was never supported. Therefore, I'm not sure how it will be handled.

rix0rrr
rix0rrr approved these changes Sep 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Let's allow the breaking change for now, we can always roll back if it causes problems.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 7, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fa2e5ae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 492d33b into aws:master Sep 7, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels

@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling effort/small Small work item – less than a day of effort pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(autoscaling): EbsDeviceVolumeType.IO2 is not a valid CloudFormation value

4 participants

@jumic @peterwoodworth @aws-cdk-automation @rix0rrr