feat(pipelines): add property to specify a namespace so exported variables can be used#15964
feat(pipelines): add property to specify a namespace so exported variables can be used#15964berenddeboer wants to merge 6 commits intoaws:masterfrom
Conversation
…ables can be used elsewhere
|
|
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.3.0...v2.4.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…uring tests (aws#15953) In v1, the default value of the @aws-cdk/core:newStyleStackSynthesis flag is false. As a consequence, Template.fromStack() generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag is true. So this test fails in the v2 branch. By explicitly setting the flag to false, we ensure that the tests passes on both v1 and v2, regardless of the default values. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… consistent template during tests (aws#15955) In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…uce a consistent template during tests (aws#15960) In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
left a comment
There was a problem hiding this comment.
Why all the unrelated changes?
I'd feel more for a codeBuildStep.variable('asdf') method which creates a unique namespace and returns the corresponding '#{MyStep1481.asfd}' expression.
|
Unrelated changes: must have come in when I tried rebase against latest, sorry about that. I will try the update branch button here in the future. I like your proposal: should that also insert things into the exported section of |
Weeelll... it could, but I'm not sure we can make that SUPER easy and obvious. Better to leave the underlying CodeBuild mechanism there I think. |
924c117 to
ebfd5f2
Compare
|
@rix0rrr Is there still an interest in pursuing this feature? I have to ask, since you closed my related PR for absolutely no reason. |
|
#17189 is closer to what I want, so I will be finishing that one. |
The pipelines interface currently does not allow setting the namespace of an action. And no "automatic" namespaces are created.
This addition allows specifying
variableNamespaceon aCodeBuildStep.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license