Skip to content

chore: align v2 alpha package naming conventions to proposal#15949

Merged
mergify[bot] merged 2 commits intov2-mainfrom
njlynch/v2-alpha-final-naming
Aug 9, 2021
Merged

chore: align v2 alpha package naming conventions to proposal#15949
mergify[bot] merged 2 commits intov2-mainfrom
njlynch/v2-alpha-final-naming

Conversation

@njlynch
Copy link
Copy Markdown
Contributor

@njlynch njlynch commented Aug 9, 2021

The proposal for what conventions to use for naming the individually-published
experimental packages has changed a few times, and the current implementation
was the work-in-progress naming.

This change aligns the implementation to the latest proposal.

closes #15576

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@njlynch njlynch added the pr/requires-two-approvers This PR is critical (e.g., security, broadly-impacting) and requires 2 approvers to be merged. label Aug 9, 2021
@njlynch njlynch requested a review from a team August 9, 2021 16:23
@njlynch njlynch self-assigned this Aug 9, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 9, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 9, 2021
@njlynch njlynch force-pushed the njlynch/v2-alpha-final-naming branch from d84ffb3 to 2e1daf8 Compare August 9, 2021 16:24
@njlynch
Copy link
Copy Markdown
Contributor Author

njlynch commented Aug 9, 2021 •
edited
Loading

Note: I marked this PR as "require-two-approvers" as a means of attaining at least a degree of consensus. The intent is for this PR to be the "final comments period" for the naming decision.

For convenience, the proposed naming is as follows:

  • NodeJS:
    • module name is @aws-cdk/aws-<service>-alpha (V1: @aws-cdk/aws-<service>)
  • Java:
    • groupId: software.amazon.awscdk (V1: same)
    • artifactId: <service>-alpha (V1: <service>)
    • Java package: software.amazon.awscdk.services.<service>.alpha (V1: software.amazon.awscdk.services.<service>)
  • C#:
    • packageId: Amazon.CDK.AWS.<Service>.Alpha (V1: Amazon.CDK.AWS.<Service>)
    • C# namespace: Amazon.CDK.AWS.<Service>.Alpha. (V1: Amazon.CDK.AWS.<Service>)
  • Python:
    • distName: aws-cdk.aws-<service>-alpha (V1: aws-cdk.aws-<service>)
    • module: aws_cdk.aws_<service>_alpha (V1: aws_cdk.aws_<service>)
  • Go:
    • github.com/aws/aws-cdk-go/awscdk/<service>alpha (V2 stable: github.com/aws/aws-cdk-go/awscdk/<service>)

@njlynch
chore: align v2 alpha package naming conventions to proposal
9bfd684 
The proposal for what conventions to use for naming the individually-published
experimental packages has changed a few times, and the current implementation
was the work-in-progress naming.

This change aligns the implementation to the latest proposal.

closes #15576
@njlynch njlynch force-pushed the njlynch/v2-alpha-final-naming branch from 2e1daf8 to 9bfd684 Compare August 9, 2021 16:28
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Aug 9, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e1f8c25
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7d026c3 into v2-main Aug 9, 2021
@mergify mergify bot deleted the njlynch/v2-alpha-final-naming branch August 9, 2021 18:13
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 9, 2021

Thank you for contributing! Your pull request will be automatically updated and merged (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

+1 more reviewer

@eladb eladb eladb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@njlynch njlynch

Labels

contribution/core This is a PR that came from AWS. pr/requires-two-approvers This PR is critical (e.g., security, broadly-impacting) and requires 2 approvers to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@njlynch @aws-cdk-automation @otaviomacedo @eladb