feat(kinesisfirehose): destinations can provide resources to be depended on by the delivery stream#15676
Merged
mergify[bot] merged 4 commits intomadeline-k/feat/kinesisfirehose-deliverystreamfrom Jul 20, 2021
Conversation
…ded on by the delivery stream
|
|
madeline-k
reviewed
Jul 20, 2021
| scope: Construct, | ||
| props: DestinationLoggingProps, | ||
| ): firehose.CfnDeliveryStream.CloudWatchLoggingOptionsProperty | undefined { | ||
| ): { loggingOptions: firehose.CfnDeliveryStream.CloudWatchLoggingOptionsProperty, dependables: cdk.IDependable[] } | undefined { |
Contributor
There was a problem hiding this comment.
I think you could consider creating a named type for this
madeline-k
approved these changes
Jul 20, 2021
Contributor
madeline-k
left a comment
There was a problem hiding this comment.
Optional to create a named type for createLoggingOptions return value.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license