chore: fix versions of inner dependencies in @aws-cdk-lib#15648
Merged
mergify[bot] merged 1 commit intoaws:v2-mainfrom Jul 19, 2021
Merged
chore: fix versions of inner dependencies in @aws-cdk-lib#15648mergify[bot] merged 1 commit intoaws:v2-mainfrom
mergify[bot] merged 1 commit intoaws:v2-mainfrom
Conversation
The build of the V2 experimental modules hardcoded the versions of unstable-to-unstable dependencies to `0.0.0`, which does not work in our pipeline, which first runs the `align-versions.sh` script to give all modules a temporary version. Fix it by using the version the experimental package itself is (as that's the version assigned by `align-versions.sh`).
|
|
eladb
approved these changes
Jul 19, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build of the V2 experimental modules hardcoded the versions of unstable-to-unstable dependencies to
0.0.0,which does not work in our pipeline, which first runs the
align-versions.shscript to give all modules a temporary version.Fix it by using the version the experimental package itself is (as that's the version assigned by
align-versions.sh).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license