Skip to content

chore: forward merge 'master' into 'v2-main'#14601

Merged
eladb merged 5 commits intov2-mainfrom
v2/forward-merge-20210508
May 11, 2021
Merged

chore: forward merge 'master' into 'v2-main'#14601
eladb merged 5 commits intov2-mainfrom
v2/forward-merge-20210508

Conversation

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented May 8, 2021

Automated action from aws/cdk-ops

Niranjan Jayakar and others added 3 commits May 7, 2021 13:56
`calculateFunctionHash()` was used to compute the 'refresh token' of the
custom resource for the EdgeFunction construct.

This method is private to the lambda module and is deemed to be changed.
Instead, use the lambda function version's logical id.

The logical id of the version includes computing the function hash (among
others) and is a more reliable determinant of whether the underlying
function version changed.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…3116) (#14365)

As per #3116, the changes in this PR validate metric dimension values (length, and checking if the value is null or undefined) and throw errors if the values are not valid. I've also corrected a comment in the metric-types.ts to use the correct method name
…e classes (#14432)

BREAKING CHANGE: HealthChecks require use of static factory methods

fixes #11640

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added pr/auto-approve Notifies the GH action to auto-approve this PR pr/forward-merge PR label to indicate forward merges of master to v2-main pr/no-squash This PR should be merged instead of squash-merging it labels May 8, 2021
@gitpod-io
Copy link

gitpod-io bot commented May 8, 2021

@eladb eladb enabled auto-merge (squash) May 11, 2021 08:48
@eladb eladb merged commit b125113 into v2-main May 11, 2021
@eladb eladb deleted the v2/forward-merge-20210508 branch May 11, 2021 09:34
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: eb00de4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/auto-approve Notifies the GH action to auto-approve this PR pr/forward-merge PR label to indicate forward merges of master to v2-main pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants