chore(core): remove deprecated construct dependency APIs#13871
chore(core): remove deprecated construct dependency APIs#13871mergify[bot] merged 6 commits intov2-mainfrom
Conversation
Delete bunch of remaining APIs that are deprecated and available in constructs 10.x Follow up of #12054
|
|
| @@ -1177,7 +1177,7 @@ export class Vpc extends VpcBase { | |||
| */ | |||
| private subnetConfiguration: SubnetConfiguration[] = []; | |||
|
|
|||
There was a problem hiding this comment.
At a glance, it looks like many of these can be applied to master instead of v2-main.
| * required to call the Grant factory functions. | ||
| */ | ||
| export class Grant implements cdk.IDependable { | ||
| export class Grant implements IDependable { |
There was a problem hiding this comment.
could we do export class Grant implements cdk.IDependable, IDependable { on master, and mark the former as deprecated?
| class LookedUpVpc extends VpcBase { | ||
| public readonly vpcId: string; | ||
| public readonly internetConnectivityEstablished: IDependable = new ConcreteDependable(); | ||
| public readonly internetConnectivityEstablished: IDependable = new DependencyGroup(); |
There was a problem hiding this comment.
similar. can we mark internetConnectivityEstablished as deprecated and introduce new equivalent props?
|
@nija-at following on our chat, let me know if you approve this. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Delete bunch of remaining APIs that are deprecated and available in constructs 10.x
Follow up of #12054
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license