chore(aws-cdk-lib): revert raising the min node version to v14#12704
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 26, 2021
Merged
chore(aws-cdk-lib): revert raising the min node version to v14#12704mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
This reverts commit 4aa64c8 This change is incompatible with our build image 'jsii/superchain' that has node v10 as its requirement. We would still like the default version of this build image to stay at v10 since that is the minimum supported version of CDKv1. Additional work is required in this area before we can raise the node version requirement for this package.
|
|
RomainMuller
approved these changes
Jan 26, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4aa64c8
This change is incompatible with our build image 'jsii/superchain' that
has node v10 as its requirement. We would still like the default version
of this build image to stay at v10 since that is the minimum supported
version of CDKv1.
Additional work is required in this area before we can raise the node
version requirement for this package. Reverting now so we don't have
a blocked pipeline.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license