Skip to content

docs(apigateway): change "full working example" link to embed example#11384

Merged
mergify[bot] merged 11 commits intomasterfrom
fix-apigateway-example-link
Nov 19, 2020
Merged

docs(apigateway): change "full working example" link to embed example#11384
mergify[bot] merged 11 commits intomasterfrom
fix-apigateway-example-link

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 10, 2020

The relative link given for the "full working example" works fine here on GitHub, but not when this is compiled into one of the API references.

Change the link to be a complete URL so it works from anywhere this content ends up.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The relative link given for the "full working example" works fine here on GitHub, but not when this is compiled into one of the API references.

Change the link to be a complete URL so it works from anywhere this content ends up.
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Nov 10, 2020

@ghost ghost requested a review from nija-at November 10, 2020 00:48
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 10, 2020
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 10, 2020

@nija-at Ready for another look.

@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 11, 2020

@nija-at OK, think I've got it now.

@nija-at nija-at changed the title [docs]: change "full working example" link to use complete URL docs(apigateway): change "full working example" link to use complete URL Nov 12, 2020
Copy link
Copy Markdown
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerry-aws - since the integ file itself was renamed, the expected files no longer match up.

@ghost ghost changed the title docs(apigateway): change "full working example" link to use complete URL docs(apigateway): change "full working example" link to embed example Nov 18, 2020
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 18, 2020

@shivlaks I think I fixed it but I see the CodeBuild is still failing... but I don't have permission to see the details

@nija-at
Copy link
Copy Markdown
Contributor

nija-at commented Nov 19, 2020

@jerry-aws - a link to the build logs is posted as a comment. You can find it just above your previous comment.

The PR had to be merged from live and should fix the failing build.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e8a8c1c into master Nov 19, 2020
@mergify mergify bot deleted the fix-apigateway-example-link branch November 19, 2020 12:02
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 36a864b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants