feat(cloudfront): support for origin request policies#10765
Merged
mergify[bot] merged 1 commit intomasterfrom Oct 7, 2020
Merged
feat(cloudfront): support for origin request policies#10765mergify[bot] merged 1 commit intomasterfrom
mergify[bot] merged 1 commit intomasterfrom
Conversation
skinny85
approved these changes
Oct 7, 2020
Contributor
skinny85
left a comment
There was a problem hiding this comment.
LGTM!
I think the "expected" JSON file for the integ test is missing?
f604fe6 to
02cb6c0
Compare
Support for the new Origin Request Policy concept in CloudFront, which provides greater control to users over what values are forwarded to the origin from the original viewer request. _Implementation Notes:_ * *Heavily* influenced by #10656, including the same notes on not extending from `IResource` and excluding the `lastModifiedTimestamp`. fixes #9647
02cb6c0 to
1c4da90
Compare
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for the new Origin Request Policy concept in CloudFront, which provides
greater control to users over what values are forwarded to the origin from the
original viewer request.
Implementation Notes:
IResourceand excluding thelastModifiedTimestamp.origin request policies cannot be used without cache policies.
fixes #9647
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license