fix(lambda): grantInvoke on imported function fails#10622
Merged
mergify[bot] merged 7 commits intomasterfrom Oct 12, 2020
Merged
fix(lambda): grantInvoke on imported function fails#10622mergify[bot] merged 7 commits intomasterfrom
mergify[bot] merged 7 commits intomasterfrom
Conversation
rix0rrr
reviewed
Oct 5, 2020
PR #8828 added the ability to add permissions on imported functions, if the account on the stack and imported function matched. However, when this doesn't match, attempting to call `grantInvoke` on the imported function results in a `findChild` error. This change guards against calling `addPermission` when `canCreatePermissions` is false by checking if the `CfnPermission` was actually created, and adjusting the return from `addInvoke` appropriately. fixes #10607
15f2877 to
cff3888
Compare
…t-invoke-imported
nija-at
approved these changes
Oct 8, 2020
njlynch
commented
Oct 8, 2020
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8828 added the ability to add permissions on imported functions, if the
account on the stack and imported function matched. However, when this doesn't
match, attempting to call
grantInvokeon the imported function results in afindChilderror.This change guards against calling
addPermissionwhencanCreatePermissionsis false by checking if the
CfnPermissionwas actually created, and adjustingthe return from
addInvokeappropriately.fixes #10607
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license