Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 31f35b9
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Long awaited :). Thanks!

Long awaited :). Thanks!

@alexpulver our pleasure. If you have any feedback on the cloudformation-include library, please let us know!

One thing I already noticed, is that adding cloudformation-include module to the project dependencies pulls in almost all (or all) other AWS CDK modules, resulting in ~200MB virtual environment size (in Python case). I assume this is by design, since these are required for casting the resources, is that correct?

P.S.: I understand that AWS CDK moves back to monolithic packaging design anyway in CDK v2, which should improve install time for all modules.

You're exactly correct @alexpulver - cloudformation-include depends on all CDK modules that define Cfn* resources (exactly because it needs access to the underlying Cfn* classes), which is most of them, and the CDK is moving to monolithic packaging, which will include the cloudformation-include module when that transition happens.

Thanks :). Another question/feedback - I see that CfnInclude class creates a resource tree under the parent construct node. Would it make sense to just rely on the regular CDK escape hatches mechanism for CFN resource lookup and customization, without explicit CfnInclude.get_resource() calls?

That's more of an implementation detail. For example, things like Conditions, Outputs, Mappings, etc. can actually have the same names as Resources and Parameters in the template. Because of that, they're created under a different scope than this (you can even see those parent scopes in your screenshot, indexes 0 through 2 under children in CfnInclude).

Methods like get_resource, get_condition, get_output, get_mapping, etc. hide those details.